Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Policy management feature #164

Merged
merged 24 commits into from
Apr 28, 2021
Merged

Policy management feature #164

merged 24 commits into from
Apr 28, 2021

Conversation

angelmoo
Copy link
Contributor

Changes for new a new vcert feature, “policy management”, This chances contains:

Creating policy from a policy specification file on TPP and Venafi cloud.
Modifying a policy using a policy specification file on TPP and Venafi cloud.
Getting a policy specification details fromTPP and Venafi cloud.
Test suite for testing this new feature.

angelmoo and others added 17 commits March 9, 2021 10:28
@angelmoo
first commit for policy management feature
393da37
@angelmoo
adding changes for supporting policy management on venafi cloud
6d05596
@angelmoo
applying format to the code
647ed00
@angelmoo
fix some falling cases and handle some NPE
03d3c82
@angelmoo
validating against npe
f952547
@angelmoo
adding changes to validate default keypair and changing some values t…
f3d631f 
…o boolean value to 0 or 1 values
@tr1ck3r
Make gofmt happy and fix keypPair typo
d40c5e1
@tr1ck3r
Minor help and error message updates
49af7e6
@angelmoo
fix for bugs found on initial tests, and change on the way the mechan…
4ce24df 
…ism get policy information on tpp
@angelmoo
fixed typos and some change requests on structures found on testing
768e699
@angelmoo
fixed an issue when policy is not set, recommended settings are not b…
806acfb 
…eing updated on VC
@angelmoo
adding new attribute autoInstalled on PS, bug fixes and remove user/p…
f19dad5 
…assword on setpolicy and getpolicy commands
@angelmoo
adding trust-bundle flag and fix issues found on testing
72848e5
@angelmoo
adding AutoInstalled atrribute on empty PS json
0506a2b
@angelmoo
added tracking data for entrust CA, and some additional fields on pro…
39a288d 
…duct when CA is digicert
@angelmoo
changes to make caName more readable on policy specification when we …
6d5f113 
…get a policy from cloud
@angelmoo
odified messages and added test cases
f9e90b5
rvelaVenafi
rvelaVenafi approved these changes Apr 22, 2021
View reviewed changes
Copy link
Contributor

@rvelaVenafi rvelaVenafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code has been carefully reviewed for the past week or two. Looks good. Minor issues were previously reported and fixed.

marcos-albornoz
marcos-albornoz reviewed Apr 27, 2021
View reviewed changes
cmd/vcert/validators.go Outdated Show resolved Hide resolved
cmd/vcert/commands.go Outdated Show resolved Hide resolved
cmd/vcert/commands.go Outdated Show resolved Hide resolved
cmd/vcert/validators.go Outdated Show resolved Hide resolved
pkg/policy/constants.go Outdated Show resolved Hide resolved
pkg/policy/constants.go Outdated Show resolved Hide resolved
pkg/policy/policyUtils.go Show resolved Hide resolved
pkg/venafi/cloud/connector.go Outdated Show resolved Hide resolved
pkg/venafi/cloud/connector.go Outdated Show resolved Hide resolved
@angelmoo angelmoo merged commit 0f0efd9 into master Apr 28, 2021
@angelmoo angelmoo deleted the policy-management-feature branch April 28, 2021 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcos-albornoz marcos-albornoz marcos-albornoz approved these changes

@rvelaVenafi rvelaVenafi rvelaVenafi approved these changes

@tr1ck3r tr1ck3r Awaiting requested review from tr1ck3r tr1ck3r is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@angelmoo @rvelaVenafi @marcos-albornoz @tr1ck3r @jdw2465VEN